Skip to content

TensorflowGNN transformer - #353

Merged
gitbuda merged 18 commits into
memgraph:mainfrom
post2web:tfgnn_transformer
Feb 16, 2026
Merged

TensorflowGNN transformer#353
gitbuda merged 18 commits into
memgraph:mainfrom
post2web:tfgnn_transformer

Conversation

@post2web

@post2web post2web commented May 19, 2025

Copy link
Copy Markdown
Contributor

Description

Contribution for issue #350

Pull request type

Please delete options that are not relevant.

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring with functional or API changes
  • Refactoring without functional or API changes
  • Build or packaging related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Closes #350

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

######################################

Reviewer checklist (the reviewer checks this part)

  • Core feature implementation
  • Tests
  • Code documentation
  • Documentation on gqlalchemy/docs

######################################

@CLAassistant

CLAassistant commented May 19, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@post2web post2web changed the title CI test TensorflowGNN transformer May 19, 2025
@post2web
post2web marked this pull request as ready for review May 19, 2025 03:29
@katarinasupe
katarinasupe requested a review from antejavor May 19, 2025 09:27
@katarinasupe katarinasupe added this to the GQLAlchemy 1.8.0 milestone May 27, 2025
Comment thread gqlalchemy/transformations/translators/tfgnn_translator.py Outdated
Comment thread gqlalchemy/transformations/translators/tfgnn_translator.py Outdated
properties_with_missing_values.add(key)
return all_property_names, list_properties, dtypes, properties_with_missing_values

def _convert_properties_to_tensors(self, properties_list: List[Dict[str, Any]]) -> Dict[str, tf.Tensor]:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens with temporal, Enum or Point types from Memgraph?

Comment thread gqlalchemy/transformations/translators/tfgnn_translator.py Outdated
Comment thread gqlalchemy/transformations/translators/tfgnn_translator.py Outdated
Comment on lines +26 to +29
def test_export_homoginious_graph(memgraph: Memgraph):
"""
Test exporting homoginious graph (nodes without labels)
"""

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

homogeneous graph (not homoginious). Fix in test name and docstring

Comment on lines +43 to +46
def test_export_heteroghinious_graph(memgraph: Memgraph):
"""
Test exporting heteroghinious graph (nodes with one label)
"""

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heterogeneous graph (not heteroghinious). Fix in test name and docstring

Comment on lines +57 to +60
def test_export_heteroghinious_multi_label_graph(memgraph: Memgraph):
"""
Test exporting heteroghinious graph and nodes with more than one label
GraphTensor will create a node for every label and edge type for each combination of source / target labels

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heterogeneous graph (not heteroghinious). Fix in test name and docstring

@katarinasupe

katarinasupe commented Jun 2, 2025

Copy link
Copy Markdown
Contributor

Hi @post2web, I left some comments, if you can take a look.
Also, I added changes made with black formatter locally (poetry run black .), so I recommend you do that before the next commit 🙏
My colleague @antejavor will also take a look at the PR and leave some comments if needed.

Also, it would be great if you could contribute to the translators documentation, which refers to import and export guides.

@antejavor antejavor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small comments, the rest looks good IMO.

EDIT: I have deleted my comments, leaving to @katarinasupe to approve.

@gitbuda
gitbuda self-requested a review February 13, 2026 17:52
@gitbuda
gitbuda merged commit 590e3d7 into memgraph:main Feb 16, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create TensorflowGNN translator

5 participants